Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Persistence] Decide and document invalid transaction handling #871

Open
13 tasks
dylanlott opened this issue Jul 3, 2023 · 2 comments
Open
13 tasks

[Persistence] Decide and document invalid transaction handling #871

dylanlott opened this issue Jul 3, 2023 · 2 comments
Assignees
@dylanlott
Labels
code health Nice to have code improvement documentation Improvements or additions to documentation persistence Persistence specific changes
Milestone
M1: Pocket PoS (P...

Comments

@dylanlott
Copy link
Contributor

dylanlott commented Jul 3, 2023 •
edited by Olshansk
Loading

Objective

Determine the full lifecycle of an invalid transaction in Pocket and how it relates to other transactions.
#861 revealed inconsistencies in how we treat invalid transactions in the block application flow.

Origin Document

The team discussed this in detail during protocol hour on 06/20/2023 (notion notes here and audio recording here).

The notes (which are rough and have not been organized) and recording (which would need to be transcribed) can be used as a starting point for how to approach this.

Goals

  • Document invalid transaction handling
  • Determine network actions and consequences for invalid transactions

Deliverable

  • Documentation updates for the transaction lifecycle
  • Necessary code updates to support the invalid transaction handling decisions
  • Prepare an ADR documenting the decision above
  • Identify & document attack vectors covered and those that should be taken into consideration in the future

Non-goals / Non-deliverables

  • Should not change any atomicity guarantees for transactions

General issue deliverables

  • Update the appropriate CHANGELOG(s)
  • Update any relevant local/global README(s)
  • Update relevant source code tree explanations
  • Add or update any relevant or supporting mermaid diagrams

Testing Methodology

  • make test_e2e
  • make develop_test
  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md
  • k8s LocalNet: verify a k8s LocalNet is still functioning correctly by following the instructions here

Creator: @dylanlott
Co-owner: @Olshansk
@dylanlott dylanlott added documentation Improvements or additions to documentation persistence Persistence specific changes code health Nice to have code improvement labels Jul 3, 2023
@dylanlott dylanlott self-assigned this Jul 3, 2023
@Olshansk
Copy link
Member

Olshansk commented Jul 3, 2023

@dylanlott I did the following:

  1. Added an origin document
  2. Added a couple deliverables
  3. Added myself as a co-owner for reference

Lmk if 👍 ?

@dylanlott
Copy link
Contributor Author

Lmk if 👍 ?

LGTM 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dylanlott dylanlott

Labels
code health Nice to have code improvement documentation Improvements or additions to documentation persistence Persistence specific changes
Projects
V1 Dashboard
Status: Backlog
Milestone
M1: Pocket PoS (Proof of Stake)
Development

No branches or pull requests
2 participants
@Olshansk @dylanlott