Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[P2P] Consolidate/refactor node identity #729

Open
11 tasks
bryanchriswhite opened this issue May 4, 2023 · 0 comments
Open
11 tasks

[P2P] Consolidate/refactor node identity #729

bryanchriswhite opened this issue May 4, 2023 · 0 comments
Assignees
Labels
consensus Consensus specific changes p2p P2P specific changes

Comments

@bryanchriswhite
Copy link
Contributor

bryanchriswhite commented May 4, 2023

Objective

Implement the consolidation and refactoring of node IDs/identity as described in the 4 ADRs resulting from the previous research spike. The goal is to simplify the codebase, create a single source of truth for IDs, and improve the overall structure and maintainability of the code.

Origin Document

Research spike on consolidating/refactoring node identity.

Resulting ADRs:

Goals

  • Implement the recommendations from the 4 ADRs
  • Consolidate and refactor node IDs/identity throughout the codebase
  • Improve the codebase maintainability and structure

Deliverable

Non-goals / Non-deliverables

  • Changes or modifications unrelated to the implementation of the 4 ADRs
  • Refactoring of the codebase beyond the scope of node IDs/identity

General issue deliverables

  • Update the appropriate CHANGELOG
  • Update any relevant READMEs (local and/or global)
  • Update any relevant global documentation & references
  • If applicable, update the source code tree explanation
  • If applicable, add or update a state, sequence or flowchart diagram using mermaid

Testing Methodology

  • All tests: make test_all
  • LocalNet: verify a LocalNet is still functioning correctly by following the instructions at docs/development/README.md

Creator: @bryanchriswhite @jessicadaugherty

@bryanchriswhite bryanchriswhite self-assigned this May 4, 2023
@jessicadaugherty jessicadaugherty added p2p P2P specific changes consensus Consensus specific changes labels May 14, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
consensus Consensus specific changes p2p P2P specific changes
Projects
Status: Rescope
Development

No branches or pull requests

2 participants