-
Notifications
You must be signed in to change notification settings - Fork 10
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
RainTree Spec Doc Version 1.0.1 Changes #21
Comments
Rather than saying If you have a paragraph in the beginning explaining these terms are interchangeable and then specifying "we will use term X moving forward`, that is the best of all worlds.
Agreed.
We use You should also make a note that E.g. the root in trees is at height 0, but for us, it is the max level. Ideally, we'll align this, but I believe it is out of scope for now (just improve and iterate).
The node position is defined as follows: Assuming all the nodes are geographically sorted based on their addresses, the node's position is its index. Does that clarify it? If so, I believe we should simply add that.
Those two look the same to me. Left should be * 1/3 * and right should be `* 2 / 3*
What if we have a 10 layer tree and 5 demotions we are at layer 5?
I think there's opportunity to just cleanup some of the text and overflow flow of the document. cc @derrandz for context. |
Overview
These are just notes on what i'm planning on changing in the spec doc. I wanted to outline what I think should be changed before aping into the doc itself.
@Olshansk and CC: @BenVanGithub
Terminology:
"Max possible layers" should be removed
Reason:
- Determining the max layer isn't necessary for the node to begin working. all that is needed is to know where to start which is calculating the top layer and working itself down.
Remove distance base metric(DBM) from the doc
Reason:
- It is confusing to the readers to see that the tree is built via the DBM when really it's it's the Target List Size(TLS) that dictates and changes the structure based on the peers that are constantly being updated.
Example from the doc:
"RainTree requires that the peer list/neighbors list be sorted based on the distance metric."
- Really it's just the logical position on the peer list. so saying DBM confuses the reader so taking it out can help clear up a lot of confusion.
change level to layers:
Reason:
- Reduce confusion for readers since they are used interchangeably
Formula
Remove the node position from the left and right branch formula:
Reason:
- as of now the formula has it as:
Node position + targetListSize/3 (rollover if needed)
since it doesn't have a numerical value I think it will be best to just remove it and update the formula to be:Left branch = targetListSize/3 (rollover if needed)
Note: should the left branch be the smaller number and the right branch be the higher? if so, then the formula needs to be swapped to be:
Left branch = targetListSize/1.5 (rollover if needed)
andRight Branch = targetListSize/1.5 (rollover if needed)
Update formula for target list size
Reason:
(topLayer - currentLayer) x 0.666 x Size of full list
the answer kept coming out as1
which concludes that we can replace the:(topLayer - currentLayer)
to just be1
as shown below:Additional Notes:
The text was updated successfully, but these errors were encountered: