Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Compiling sass for theme gives error #58

Open
TG-March opened this issue Oct 28, 2024 · 2 comments
Open

Compiling sass for theme gives error #58

TG-March opened this issue Oct 28, 2024 · 2 comments
Assignees
Labels
waiting answer waiting for user response

Comments

@TG-March
Copy link

TG-March commented Oct 28, 2024

_html-grid.scss syntax is incorrect and won't compile with SASS.

error sass/libs/_html-grid.scss (Line 117: Undefined operation: "calc(100% / $cols) times 1".)
error sass/libs/_html-grid.scss (Line 121: Undefined operation: "calc(100% / $cols) times 1".)

The original here compiles OK:

https://github.com/ajlkn/responsive-tools/blob/master/src/_html-grid.scss

I changed $cols definition to match the original and it was fine.

@pmoreno-rodriguez pmoreno-rodriguez self-assigned this Oct 28, 2024
@pmoreno-rodriguez pmoreno-rodriguez added the bug Something isn't working label Oct 28, 2024
@pmoreno-rodriguez
Copy link
Owner

Thanks @TG-March. I'll fix in next version

@pmoreno-rodriguez
Copy link
Owner

pmoreno-rodriguez commented Oct 28, 2024

BTW, in Visual Code with SASS compile extension, compiling sass code without calc function display the following:

Warning:
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, $cols) or calc(100% / $cols)

More info and automated migrator: https://sass-lang.com/d/slash-div
   ╷
12 |			$unit: 100% / $cols;
   |         ^............^
   ╵
file:///var/www/devel/future/user/themes/future2021/assets/sass/libs/_html-grid.scss:12:10
THIS IS DEPRECATED AND WILL BE REMOVED IN SASS 2.0
--------------------
Warning:
Using / for division outside of calc() is deprecated and will be removed in Dart Sass 2.0.0.

Recommendation: math.div(100%, $cols) or calc(100% / $cols)

More info and automated migrator: https://sass-lang.com/d/slash-div
   ╷
12 |			$unit: 100% / $cols;
   |         ^............^
   ╵
file:///var/www/devel/future/user/themes/future2021/assets/sass/libs/_html-grid.scss:12:10
THIS IS DEPRECATED AND WILL BE REMOVED IN SASS 2.0

Can you try with $unit: math.div(100%, $cols); ?

I would like to use sass code with the latest specifications.

@pmoreno-rodriguez pmoreno-rodriguez added waiting answer waiting for user response and removed bug Something isn't working labels Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
waiting answer waiting for user response
Projects
None yet
Development

No branches or pull requests

2 participants