Garbage Collection Cycle Count Increases on Player Disconnect

[kostamax27]

Issue description

• Expected result: Running /gc in the console should show Cycles: 0 after a player disconnects.
• Actual result: Running /gc shows Cycles: 38 after a player disconnects.

This issue is caused by this code:

PocketMine-MP/src/inventory/ArmorInventory.php

Line 45 in b3b8aad

$this->validators->add(new CallbackSlotValidator($this->validate(...)));

Steps to reproduce the issue

1. Join the game.
2. Quit the game.
3. Use /gc in the console to check the garbage collection cycle count.

OS and versions

• PocketMine-MP: 5.21.0

Plugins

Plugins (0):

• If you remove all plugins, does the issue still occur? Yes

[dktapps]

Yeah, we had problems like this before with DelegateInventory. It needs to use a weakref to reference $this.

[ShockedPlot7560]

Right, the slot validator is a new feature, thanks !