Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Verify all non pocketmine. prefixed translations are present in vanilla translation files #149

Open
dktapps opened this issue Dec 25, 2022 · 0 comments

Comments

@dktapps
Copy link
Member

dktapps commented Dec 25, 2022

Any string that isn't prefixed by pocketmine. is expected to be automatically translated by the client, if given the opportunity.

We allow this because it avoids the need for the server to match the client and server language for some translations. However, it's problematic when translations are changed or removed in vanilla, because then issues like pmmp/PocketMine-MP#5471 crop up, or various other issues where translation keys have been altered (e.g. the old commands.gamemode.success bug in 2016).

We can possibly detect these problems by validating the translations against those provided publicly by Mojang here: https://github.com/Mojang/bedrock-samples/tree/main/resource_pack/texts

While we can't include these files in PocketMine-MP directly due to licensing incompatibility, we can use them for validating our own.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant