Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid options #138

Open
wathen opened this issue Aug 5, 2024 · 0 comments · May be fixed by #139
Open

Invalid options #138

wathen opened this issue Aug 5, 2024 · 0 comments · May be fixed by #139
Assignees
@wathen

Comments

@wathen
Copy link
Member

wathen commented Aug 5, 2024

As noticed in #51, there is no guard for invalid options. Go through modules and raise error if invalid option set, something like this:

if opt1:
    ...
elif opt2:
    ...
else
    throw exception
fi
@wathen wathen self-assigned this Aug 5, 2024
@wathen wathen linked a pull request Aug 5, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@wathen wathen

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding minimum and maximum values to get_parameters in ERSEM pmlmodelling/ersem
1 participant
@wathen