Question: next steps in dev-stack?

[1letter]

I have working on SVG-Flag-Files Support in the Language Selector.

4 Packages are involved:

• plone.staticresources
• plone.i18n
• plone.app.i18n
• plone.app.multilingual

What i have done:

• branching and working on every package
• locally all is fine
• push my branches to remote

My Question: what are the next steps in order not to lose the overview of things? Should i do PR in every repro (probably yes)? But everything is related, what happen if one PR is accepted but another not? Is here in the coredev anything needed? Should i update the checkouts.cfg?

[mauritsvanrees]

What I would usually do:

1. Create one overall issue in Products.CMFPlone that you can link to and generally keep track of what still needs to happen.
2. Create PRs for all packages. In each PR link to the main issue and make it clear that this PR belongs to other PRs and they need to be merged together.
3. Login on Jenkins, go to the relevant jobs and in the dropdown click on 'Build with parameters'. In the form, copy the URLs of all PRs.

Alternative to step 3 is to edit the sources.cfg of the coredev buildout to point to your branches instead of master (or main). Make sure they are in the checkouts too. Create a branch of coredev and make a PR of that. This makes it a bit easier for others: they can just checkout your coredev branch, run buildout, and test it. When all is approved, the coredev PR should not be merged, but closed, and the other PRs merged instead.

When PRs that belong together get merged, Jenkins probably already starts after the merge of the first, which may mean Jenkins gets failures, but that can't be avoided. Once all are merged, Jenkins should be green again.