Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unused 2023_ploneconf-frontend-auth middleware #28

Open
Fosten opened this issue Aug 24, 2023 · 0 comments
Open

Unused 2023_ploneconf-frontend-auth middleware #28

Fosten opened this issue Aug 24, 2023 · 0 comments

Comments

@Fosten
Copy link

Fosten commented Aug 24, 2023

Traefik configs are working fine, but it appears as if a few lines of code could be cleaned up.

This is an unused middleware as Auth is not needed on public site 2023.ploneconf.org. Label could be removed.

### ClassicUI Access Authentication
- traefik.http.middlewares.2023_ploneconf-frontend-auth.basicauth.users=ploneconf:$$2y$$05$$SLsKIKgK.NlD.64HMV42hOUNi3pQM/T.iW4qziWs0xcKHzkaa8T8C

As you can see, the 2023_ploneconf-frontend-auth middleware is not referenced here anyway.

- traefik.http.routers.2023_ploneconf-frontend.middlewares=gzip

This is the correct use of middleware as Auth is needed on private site testing.ploneconf.org

### ClassicUI Access Authentication
- traefik.http.middlewares.testing_ploneconf-frontend-auth.basicauth.users=ploneconf:$$2y$$05$$SLsKIKgK.NlD.64HMV42hOUNi3pQM/T.iW4qziWs0xcKHzkaa8T8C

As you can see, the testing_ploneconf-frontend-auth middleware is actually referenced here.

- traefik.http.routers.testing_ploneconf-frontend.middlewares=gzip,testing_ploneconf-frontend-auth

Change comment here to ### testing.ploneconf.org Access Authentication

### ClassicUI Access Authentication

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant