-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upload sourcemaps to Azure from CI #91
Comments
I would presume Oryx would pick up that it's a Webpack/CRA installation from Node deps or that there's a Node build script, and run it that way, in which case it would all go through webpack (which is admittedly obscured by CRA) which should be generating sourcemaps already I thought, unless it was disabled, in any case it shouldn't be terribly difficult to re-enable them I think? I'll have to look into it a little |
@ashleylamont yeah it generates sourcemaps, but I'm not sure how to get those from Oryx into a Blob container |
After digging a bit deeper, we would need to move builds from Oryx to Actions as discussed in Azure/static-web-apps#17. I'm ok with that, would just have to be more careful when applying the 'safe to test' label - PRs could potentially access secrets during the build process. |
Allows unminifying code in Application Insights, as documented. Would make troubleshooting from logs much easier. Not sure if this is possible given that Azure (Oryx) handles the build, but worth investigating.
The text was updated successfully, but these errors were encountered: