Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark mode is unloved #219

Open
pl4nty opened this issue Feb 15, 2023 · 4 comments
Open

Dark mode is unloved #219

pl4nty opened this issue Feb 15, 2023 · 4 comments
Labels
enhancement New feature or request

Comments

@pl4nty
Copy link
Owner

pl4nty commented Feb 15, 2023

The dark mode currently is just pretty bad:

  • it's ugly. the dark mode is significantly uglier than the light mode because the color scheme is incohesive. it looks to just be changing the background and font colors and leaving all other colors the same, which explains why it looks so bad
  • the dark mode has a lot of white! I'd suggest lightening the background a bit so the grid lines in particular can be made darker.
  • the dark mode does not respect a user's dark/light mode preferences (e.g., @media (prefers-color-scheme: dark))
  • the subject search box is basically just broken to the point of un-usability in the dark mode

Tested in an up-to-date version of Chrome.

Label: Issue

Originally submitted by anonymous via the Microsoft Form

@jthvai
Copy link
Collaborator

jthvai commented Jan 9, 2024

2024-01-09_17:46:47

lmao

Willing to self-assign if you'd like.

@jthvai
Copy link
Collaborator

jthvai commented Jan 9, 2024

I'd also like to vote to get rid of the colourmode button altogether and replace it with @media queries.

@jthvai
Copy link
Collaborator

jthvai commented Jan 9, 2024

Blocked by #378 after discussion

@jthvai
Copy link
Collaborator

jthvai commented Jan 9, 2024

From #211:

Reproduced in Firefox and Chrome on macOS Monterey, the issue is that when Dark Mode is enabled, the text color of the page changes to become white, but the background of the course search dropdown (#react-select-2-listbox) remains white, hence the search result course names are unreadable unless you hover over them.

Tom claims to have previously fixed this, though the issue clearly still exists per the previous screenshot.

@jthvai jthvai added the enhancement New feature or request label Jan 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants