Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow plugins to extend the categories of the Publisher Library #10521

Closed
NateWr opened this issue Oct 16, 2024 · 5 comments
Closed

Allow plugins to extend the categories of the Publisher Library #10521

NateWr opened this issue Oct 16, 2024 · 5 comments
Milestone

Comments

@NateWr
Copy link
Contributor

NateWr commented Oct 16, 2024

Describe the feature
The Publisher Library allows journal managers to upload files to one of four categories. These categories are fixed and cannot be modified.

I propose that we add hooks which allow plugins to extend the categories. This will allow a plugin to make use of files uploaded to the Publisher Library.

Use Case
I have two clients who want a consistent way for journal managers to upload and manager logos for their partner institutions. This is a common challenge which journals often solve by injecting logos into the pageFooter, additionalHomepageContent, or a custom sidebar block.

These approaches do not provide sensible design constraints, so logos are often wildly different sizes and not aligned well. You can see some common examples of this UI pattern here and here.

What application are you using?
3.3.x

Additional information
If the PRs are accepted, my client plans to support me in publishing a "Partner Logos" plugin so the community can benefit from this.

NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 16, 2024
@NateWr
Copy link
Contributor Author

NateWr commented Oct 16, 2024

It looks like the postgres tests are failing in a way that doesn't look likely to be related to this PR:

psql: error: connection to server on socket "/var/run/postgresql/.s.PGSQL.5432" failed: FATAL: Peer authentication failed for user "postgres"

@NateWr
Copy link
Contributor Author

NateWr commented Oct 18, 2024

@asmecher Jonas re-ran the tests for me and they're still failing on a postgres connection error. It looks like all the pgsql tests failed in the last commit to stable-3_3_0 too, but not on this connection error: https://github.com/pkp/ojs/commits/stable-3_3_0/

NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 21, 2024
NateWr added a commit to NateWr/pkp-lib that referenced this issue Oct 21, 2024
@NateWr
Copy link
Contributor Author

NateWr commented Oct 21, 2024

@asmecher All tests are passing. Can you review? Or should I ping someone else?

@asmecher
Copy link
Member

All merged, thanks -- I'll take care of the submodules between now and the next release.

@asmecher asmecher added this to the 3.3.0-20 milestone Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants