-
Notifications
You must be signed in to change notification settings - Fork 246
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add DocSearch for searching for the documentation #817
Comments
Oh, and I found one accessibility issue with the search. Hitting tab when in the search input field should advance the focus to the next item on the page. Instead, it navigates the browser to the first result. |
An idea on the language duplicates: if we can distinguish search results by language, and always search one or another language, one possible approach would be to detect the user language set in the browser and always search that language by default. |
Using regular expressions in the Algolia config may help to distinguish by language and/or doc version. The part of this I'm not sure about though is that we have a few types of URL structures, so the language can appear in different parts of the URL, e.g.: https://docs.pkp.sfu.ca/designing-your-journal/en/ We may be able to filter with our regex though! |
For setting up a separate dev search, one option could be a separate config for the dev pages if that's allowed in their free license, then we would exclude the dev URLs from the existing Algolia config. |
Yeah, I'm terrible at regex but think we could figure out a way to do this. We should be able to detect on |
@kaitlinnewson has implemented a test site with search that uses the DocSearch service from Algolia. This issue can be used to discuss the search option's suitability and whether any adjustments can be made.
The text was updated successfully, but these errors were encountered: