Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Change-point tests #1295

Draft
wants to merge 85 commits into
base: main
Choose a base branch
from
Draft

Change-point tests #1295

wants to merge 85 commits into from

Conversation

DavAug
Copy link
Member

@DavAug DavAug commented Feb 16, 2021

Closes #1294 .

@DavAug
Copy link
Member Author

DavAug commented Feb 16, 2021

Something like this @fcooper8472 ?

@codecov
Copy link

codecov bot commented Feb 16, 2021 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 100.00%. Comparing base (e82aae3) to head (a1be118).
Report is 30 commits behind head on main.

❗ Current head a1be118 differs from pull request most recent head 3e169ba. Consider uploading reports for the commit 3e169ba to get more accurate results

Additional details and impacted files 
@@             Coverage Diff             @@
##             main     #1295      +/-   ##
===========================================
+ Coverage   96.49%   100.00%   +3.50%     
===========================================
  Files         114        84      -30     
  Lines        9925      8838    -1087     
===========================================
- Hits         9577      8838     -739     
+ Misses        348         0     -348

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@fcooper8472 fcooper8472 marked this pull request as draft February 22, 2021 23:06
@MichaelClerx
Copy link
Member

Thanks both! Looks like it would work to me, which is the most important thing :D

@fcooper8472
#1294 update structure
fdbf30d 
Defer creation of toy problem to class; define function for specific method
@fcooper8472
#1294 allow setting of hyper parameters
1225905
@MichaelClerx MichaelClerx self-requested a review March 16, 2021 11:34
@MichaelClerx MichaelClerx changed the title Functional tests Change point tests Aug 17, 2021
@MichaelClerx MichaelClerx changed the title Change point tests Change-point tests Aug 24, 2021
@MichaelClerx
Copy link
Member

@DavAug @fcooper8472 Any idea what's making the changepoint testing not work?

@MichaelClerx
Copy link
Member

And is it still the plan to have these changepoint tests in the main pints repo, or should they live somewhere else?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MichaelClerx MichaelClerx MichaelClerx left review comments

@fcooper8472 fcooper8472 Awaiting requested review from fcooper8472

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Create a functional testing module with tests for all methods
8 participants
@DavAug @MichaelClerx @fcooper8472 @ben18785 @chonlei @rccreswell @FarmHJ @YongchaoHuang