Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Certificate attribute for pingone_key resource #580

Open
kwevers opened this issue Oct 4, 2023 · 3 comments
Open

Certificate attribute for pingone_key resource #580

kwevers opened this issue Oct 4, 2023 · 3 comments
Assignees
Labels
size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/blocked/upstream-api The issue/PR is blocked by an upstream API status/triaged The issue/PR has completed initial triage and needs assignment type/enhancement/ux Enhancements specifically for user experience of the provider type/enhancement New feature or request

Comments

@kwevers
Copy link

kwevers commented Oct 4, 2023

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

Expose the generated certificate as an attribute when creating a key pair with the pingone_key resource.
In our case this would be used to store the certificate in our secret store where it can be read by Ansible for use in application configuration.

New or Affected Resource(s)

  • pingone_key

Potential Terraform Configuration

N/A

References

The web UI shows a Download Certificate button so I would expect this to be possible.
I think this is the API call required: https://apidocs.pingidentity.com/pingone/platform/v1/api/#get-export-public-key-x509-pem

@kwevers kwevers added status/needs-triage The issue/PR needs initial triage type/enhancement New feature or request labels Oct 4, 2023
@patrickcping
Copy link
Collaborator

Hi @kwevers thanks for raising!

The pingone_certificate_export data source (registry docs link) should be the equivalent of the Download Certificate button in the admin console. Would this work for your use case?

@kwevers
Copy link
Author

kwevers commented Oct 5, 2023

Hi @patrickcping,

I completely missed that datasource. Thanks!
This makes that we're not blocked right now, which is awesome, but ideally we wouldn't need to have a resource and a datasource for a single object in the same module so it would be great if this still could be added at some point.

@patrickcping
Copy link
Collaborator

Perfect. Understood. The current implementation stays faithful to the API, where it is the equivalent of a POST (to create the key) followed by a GET (to get the cert export).

Before we look to deviate from the API on the provider, I'll first check in with the API team and see whether it can be included in the response payload of the POST call

@patrickcping patrickcping added status/blocked/upstream-api The issue/PR is blocked by an upstream API status/triaged The issue/PR has completed initial triage and needs assignment type/enhancement/ux Enhancements specifically for user experience of the provider size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) and removed status/needs-triage The issue/PR needs initial triage labels Oct 5, 2023
@patrickcping patrickcping self-assigned this Oct 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size/medium Medium size change (e.g. enhancing the logic of an existing resource or datasource) status/blocked/upstream-api The issue/PR is blocked by an upstream API status/triaged The issue/PR has completed initial triage and needs assignment type/enhancement/ux Enhancements specifically for user experience of the provider type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants