Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove the requirement for the organization_id on the pingone_license and pingone_licenses datasources. Should be defaulted from the client connection. #240

Open
patrickcping opened this issue Feb 3, 2023 · 1 comment
Assignees
Labels
service/base PingOne Platform status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK status/triaged The issue/PR has completed initial triage and needs assignment type/enhancement New feature or request

Comments

@patrickcping
Copy link
Collaborator

Community Note

  • Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request
  • Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request
  • If you are interested in working on this issue or have submitted a pull request, please leave a comment

Description

The organization_id schema field is a required field of the pingone_license and pingone_licenses datasources, but is very unlikely (if ever) going to be different to the organization ID that the client connection will use in the provider {} block.

The enhancement is to make organization_id an optional field (defaulted to the organization ID that the client can provide) to reduce some friction of obtaining data about a license (or set of licenses)

New or Affected Resource(s)

  • pingone_license
  • pingone_licenses

Potential Terraform Configuration

# Copy-paste your PingOne related Terraform configurations here - for large Terraform configs,
# please use a service like Dropbox and share a link to the ZIP file. For
# security, you can also encrypt the files using our GPG public key.

# Remember to replace any account/customer sensitive information in the configuration before submitting the issue

### pingone_license - Current
data "pingone_license" "my_license" {
  organization_id = var.organization_id
  license_id      = var.license_id
}

### pingone_license - Desired
data "pingone_license" "my_license" {
  license_id      = var.license_id
}

### pingone_licenses - Current
data "pingone_licenses" "my_licenses_by_data_filter" {
  organization_id = var.organization_id

  data_filter {
    name   = "name"
    values = ["My License"]
  }

  data_filter {
    name   = "status"
    values = ["ACTIVE"]
  }
}


### pingone_licenses - Desired
data "pingone_licenses" "my_licenses_by_data_filter" {
  data_filter {
    name   = "name"
    values = ["My License"]
  }

  data_filter {
    name   = "status"
    values = ["ACTIVE"]
  }
}

References

@patrickcping patrickcping added type/enhancement New feature or request service/base PingOne Platform status/needs-triage The issue/PR needs initial triage status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK status/triaged The issue/PR has completed initial triage and needs assignment and removed status/needs-triage The issue/PR needs initial triage labels Feb 3, 2023
@patrickcping patrickcping added this to the v0.8.1 milestone Feb 3, 2023
@patrickcping patrickcping self-assigned this Feb 10, 2023
@patrickcping patrickcping modified the milestones: v0.8.1, v1.0.0 Feb 13, 2023
@patrickcping patrickcping removed this from the v1.0.0 milestone Feb 13, 2023
@patrickcping patrickcping added wontfix This will not be worked on and removed wontfix This will not be worked on labels Mar 17, 2023
@dbryar
Copy link

dbryar commented Apr 18, 2023

If the licence auto selection is smart enough it should be able to choose the "main" license from the pool. In any given organisation there is going to be active and inactive licenses, as well as an admin licence (e.g. max 50 users) and a "production" or "main" license with many thousand or millions of users.

The organisation is, as you say, unlikely to ever change and should be defaulted

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
service/base PingOne Platform status/blocked/upstream-sdk The issue/PR is blocked by an upstream SDK status/triaged The issue/PR has completed initial triage and needs assignment type/enhancement New feature or request
Projects
None yet
2 participants