Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[bug]: Multiple file uploads seem to trigger twice #965

Closed
2 tasks done
AlemTuzlak opened this issue Sep 19, 2024 · 3 comments · Fixed by #980
Closed
2 tasks done

[bug]: Multiple file uploads seem to trigger twice #965

AlemTuzlak opened this issue Sep 19, 2024 · 3 comments · Fixed by #980
Labels
area:packages issue regarding one of the uploadthing packages bug: medium priority Something isn't working status: in progress work is currently underway to address this issue

Comments

@AlemTuzlak
Copy link
Contributor

AlemTuzlak commented Sep 19, 2024

Provide environment information

System:
    OS: Windows 11 10.0.22631
    CPU: (24) x64 12th Gen Intel(R) Core(TM) i9-12900K
    Memory: 2.90 GB / 31.71 GB
  Binaries:
    Node: 20.16.0 - C:\Program Files\nodejs\node.EXE
    Yarn: 1.22.21 - ~\AppData\Roaming\npm\yarn.CMD
    npm: 10.6.0 - C:\Program Files\nodejs\npm.CMD
    pnpm: 9.8.0 - ~\AppData\Roaming\npm\pnpm.CMD
  Browsers:
    Chrome: 128.0.6613.138
    Edge: Chromium (127.0.2651.74)
    Internet Explorer: 11.0.22621.3527
  npmPackages:
    @uploadthing/react: ^7.0.2 => 7.0.2
    typescript: ^5.1.6 => 5.6.2
    uploadthing: ^7.0.2 => 7.0.2

Describe the bug

I followed your remix guide and added a multiple file dropzone
https://github.com/user-attachments/assets/c6cdf72b-9763-41a7-be9a-20bee2032876

Link to reproduction

https://stackblitz.com/~/github.com/AlemTuzlak/uploadthing-remix

To reproduce

click on the text of the dropzone and try to upload multiple files
add your key in the .env first though

Additional information

No response

👨‍👧‍👦 Contributing

  • 🙋‍♂️ Yes, I'd be down to file a PR fixing this bug!

Code of Conduct

  • I agree to follow this project's Code of Conduct
@AlemTuzlak AlemTuzlak added area:packages issue regarding one of the uploadthing packages 🐛 bug: unconfirmed labels Sep 19, 2024
@juliusmarminge
Copy link
Collaborator

cc @markflorkowski event.stopPropagation() bug that you were fighting with in #886

@markflorkowski
Copy link
Collaborator

I hadn't seen it in the react package, but yeah this sounds like the same issue

@AlemTuzlak
Copy link
Contributor Author

I added stopPropagation in the onDropCb and it seems to fix it the first time then it breaks the 2nd time you try

@juliusmarminge juliusmarminge added bug: medium priority Something isn't working and removed 🐛 bug: unconfirmed labels Sep 23, 2024
@juliusmarminge juliusmarminge added the status: in progress work is currently underway to address this issue label Sep 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:packages issue regarding one of the uploadthing packages bug: medium priority Something isn't working status: in progress work is currently underway to address this issue
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants