Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[refactor]: better error logging #781

Open
1 task done
juliusmarminge opened this issue Apr 30, 2024 · 0 comments
Open
1 task done

[refactor]: better error logging #781

juliusmarminge opened this issue Apr 30, 2024 · 0 comments
Labels
area:packages issue regarding one of the uploadthing packages PRs Accepted Anyone feel free to pick this up

Comments

@juliusmarminge
Copy link
Collaborator

juliusmarminge commented Apr 30, 2024

I understand that this issue may be closed if it should be filed in another category

  • I understand

My issue

This doesn't really log any info about the error:
CleanShot 2024-04-30 at 13 13 52@2x

For example, our FetchError class has input, error and data attributes on it, none of which are logged.

We should also use spans to get a better stack trace, essentially any of these logs shouldn't be necessary. If we have spans we should be able to just let the error bubble and log it once in a central place:
CleanShot 2024-04-30 at 13 15 46@2x

@juliusmarminge juliusmarminge added area:packages issue regarding one of the uploadthing packages PRs Accepted Anyone feel free to pick this up labels Apr 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:packages issue regarding one of the uploadthing packages PRs Accepted Anyone feel free to pick this up
Projects
None yet
Development

No branches or pull requests

1 participant