Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we really need a Revision model? #37

Closed
paltman opened this issue Feb 18, 2015 · 7 comments
Closed

Do we really need a Revision model? #37

paltman opened this issue Feb 18, 2015 · 7 comments

Comments

@paltman
Copy link
Member

paltman commented Feb 18, 2015

@jtauber do we ever use this in all the instances we use this software?

Does anyone else?

@jtauber
Copy link
Member

jtauber commented Feb 24, 2015

I can't say I've explicitly used it but I also like the idea that we have the full edit history of posts.

@rizumu
Copy link
Contributor

rizumu commented Feb 24, 2015

Now that there is https://github.com/etianen/django-reversion it doesn't seem necessary to build it into the project.

@jtauber
Copy link
Member

jtauber commented Feb 24, 2015

Yeah, I'm all for just using something like that. The thing we considered important when we first implemented the feature on the eldarion.com blog was knowing what the blog said at a particular time (i.e. having an audit trail after initial publication more than simply capturing versions during drafting)

@ossanna16
Copy link
Contributor

Any further discussion on this? 😊

@swilcox
Copy link
Contributor

swilcox commented Jan 5, 2016

I'm definitely of the "less is more" camp. Keep things smaller and simpler is good.

@jtauber
Copy link
Member

jtauber commented Jan 5, 2016

I still think it's important for (particularly a corporate) blog to know what content was visible at a point in time, which was the point of the Revision model. I'm +0 on using django-reversion for it instead and -0 on losing the functionality all together.

@paltman
Copy link
Member Author

paltman commented Jan 23, 2016

I actually think this is important to keep now if we are considering auto-saves on #62

@paltman paltman closed this as completed Jan 23, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants