Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Full width horizontal scroll #656

Open
wants to merge 42 commits into
base: 1.x
Choose a base branch
from
Open

Conversation

xIrusux
Copy link
Contributor

@xIrusux xIrusux commented Oct 28, 2024

Changes in this pull request

resolves #576

  • Rework of the horizontal scroll bar to remove the use of global overflow-x: auto class which was required when the bar is nested in several flex boxes
  • Therefore encapsulate all required behaviour in the shared component itself.
  • Change of focus to have the scroll bar span across the entire width of the toolbar which can be used in other places as well.
  • Initially tried to have an overall horizontal scroll bar for the entire width of the toolbar and inside that another horizontal scrollbar. However this brings back the requirement of adding overflow-x: auto back or passing args through both nested horizontal scroll bars to determine which needs to shrink first and when etc.

Additional info

Screen.Recording.2024-10-28.at.15.06.27.mov

@xIrusux
Copy link
Contributor Author

xIrusux commented Oct 29, 2024

implemented at a different level so the scroll automatically appears for the toolbars + pagination toolbars

Screen.Recording.2024-10-29.at.14.57.52.mov

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Implement workflow transitions and workflow state next to save button
2 participants