[Bugfix] Extend empty check to "0" for LoadingDataObject mapping

[woellundwoell]

The current check for empty in

data-importer/src/Mapping/Operator/Simple/LoadDataObject.php

Line 109 in 596fd84

if (empty($data) === false) {

also ignores the string "0". Thus it is not possible to use this for the import on attributes. Even if it does not make much sense this also applies to a path specification.
In our current project we have an identifier attribute that can have the value (the string) "0" among others. Without the fix an import is not possible here.

[robertSt7]

Hi @woellundwoell could you please rebase this to 1.8? Thanks

[woellundwoell]

@robertSt7 im not sure how to do this. Can you please point me in the right direction how to do this?

[robertSt7]

@robertSt7 im not sure how to do this. Can you please point me in the right direction how to do this?

@woellundwoell It depends on what Idea you use

For Jetbrains Idea: https://www.youtube.com/watch?v=wiU3TL3jM8I

You can also just do it on the command line with: git rebase 1.8 Make sure that you have your branch checked out and have branch 1.8 in your local environment.

If you are facing any problems, please feel free to ask. Thanks

[blankse]

@robertSt7 @woellundwoell A simple rebase doesn't work here. You need to set the --onto option, otherwise you have many commits from branch 1.x. You also need a force push than, because you have changed the history of the branch.

This should work:

git clone https://github.com/woellundwoell/data-importer.git
cd data-importer
git remote add upstream https://github.com/pimcore/data-importer.git
git fetch --all
git rebase --onto upstream/1.8 upstream/1.x
git push --force

After that you need to change the target branch of the PR to 1.8.

For the next PR I would recommend to create a new branch for it.
You shouldn't use 1.x for the PR branch.

[robertSt7]

@woellundwoell Thanks for the PR you don't need to care about the rebasing we will cherry pick it