Field type Table: Copy / Paste #715
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…a before applying to table + save changes
…a before applying to table + save changes
…a before applying to table
# Conflicts: # public/js/pimcore/object/tags/table.js
|
|
Aaaah nice, thank you 👍 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR makes the paste dialog for
tablefields more usable: Before, the paste window immediately applies the value and closes the dialog window after pasting. This means you cannot review the values. This does not only happen on pasting but on any changing of the value (so if you enter "a" (any character) in the paste dialog text area, this value also gets applied immediately).As @mcop1 suggested in #559 (comment) this PR adds a "Save" button to the paste dialog so that you can paste the content to the text area, review it and apply by clicking the "Save" button: