Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Domain Description field incorrectly escapes certain unicode symbols #3155

Closed
cmrschwarz opened this issue Oct 2, 2024 · 1 comment
Closed

Comments

@cmrschwarz
Copy link

Versions

Pi-hole version is v5.18.3 (Latest: v5.18.3)
web version is v5.21 (Latest: v5.21)
FTL version is v5.25.2 (Latest: v5.25.2)

Platform

docker (pihole/pihole:latest)

Bug

When entering a unicode symbol like ° (U+00B0, °, the degree sign) into the description field on the 'Domains' page(admin/groups-domains.php), the symbol is displayed as it's html escape string (°).

Steps to reproduce

  1. Go to the domains page (admin/groups-domains.php)
  2. Add a new domain where the description contains a °. (alternatively edit an existing one)

Expected Behavior

Like other description fields on the 'groups' or 'clients' pages, the value should not be escaped (these are <input> html elements).

Screenshot: Observed

Image

Screenshot: Expected

Image

Additional context

@cmrschwarz
Copy link
Author

cmrschwarz commented Oct 2, 2024

Ah, I just saw that #2279 / #2851 already adress this. I missed those earlier when searching for this. Please forgive me for the spam. Hopefully this at least helps the "SEO" for this problem :).
Thanks for the awesome software btw!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant