Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL-based branch changes #90

Open
jamesdabbs opened this issue Dec 9, 2023 · 1 comment
Open

URL-based branch changes #90

jamesdabbs opened this issue Dec 9, 2023 · 1 comment
Labels
enhancement New feature or request

Comments

@jamesdabbs
Copy link
Member

Spun out from #89, since I think it's going to be a little bit more work. Our ideal here would be:

  • A sharable/linkable way to reference "the viewer, with data loaded from ..."
  • Clicking around the site continues to view the same branch
  • Re-visiting the site later uses the previously stored branch (or main)

Probably some investigation needed here. I'm unsure whether this'll be implementation-wise easier with a ?branch=... query param or an optional /branch/{branch}/ base path. @StevenClontz – do you have a preference one way or the other?

@StevenClontz
Copy link
Member

StevenClontz commented Dec 9, 2023

Very very slight preference for the query string appended to the end over the prefixed route.

I said something wrong in the other thread: it's perfectly fine if the branch is always main unless the route/query string explicitly says to use an alternative branch. Probably strictly better: if I'm viewing an alternative branch I can share the URL I'm actually at with anyone and they see the same branch.

@jamesdabbs jamesdabbs added the enhancement New feature or request label Dec 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants