Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Non-canonical freedesktop path for icon file #635

Open
tim77 opened this issue Oct 9, 2024 · 1 comment
Open

Non-canonical freedesktop path for icon file #635

tim77 opened this issue Oct 9, 2024 · 1 comment
Assignees
Labels
bug fixed Fix committed to GitHub and will be available in next release

Comments

@tim77
Copy link
Contributor

tim77 commented Oct 9, 2024

Look like the proper place for Minder icon file is scalable folder since it in SVG format.

icons/hicolor/128x128/apps/com.github.phase1geo.minder.svg
to
icons/hicolor/scalable/apps/com.github.phase1geo.minder.svg

Can we try this in order to fix flathub/com.github.phase1geo.minder#40?

"errors": [
    "non-png-icon-in-hicolor-size-folder"

    "non-png-icon-in-hicolor-size-folder: ['/tmp/tmp57ti8txx/icons/hicolor/128x128/apps/com.github.phase1geo.minder.svg', '/tmp/tmp57ti8txx/icons/hicolor/24x24/apps/com.github.phase1geo.minder.svg', '/tmp/tmp57ti8txx/icons/hicolor/64x64/apps/com.github.phase1geo.minder.svg', '/tmp/tmp57ti8txx/icons/hicolor/32x32/apps/com.github.phase1geo.minder.svg', '/tmp/tmp57ti8txx/icons/hicolor/48x48/apps/com.github.phase1geo.minder.svg', '/tmp/tmp57ti8txx/icons/hicolor/16x16/apps/com.github.phase1geo.minder.svg']"
    
"message": "Please consult the documentation at https://docs.flathub.org/docs/for-app-authors/linter"
@phase1geo phase1geo self-assigned this Oct 9, 2024
@phase1geo phase1geo added bug fixed Fix committed to GitHub and will be available in next release labels Oct 9, 2024
@phase1geo
Copy link
Owner

I have fixed this issue in the master branch. It will be generally available in the upcoming 1.17 release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug fixed Fix committed to GitHub and will be available in next release
Projects
None yet
Development

No branches or pull requests

2 participants