Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[blastxml_to_tabular] Add an option to print Header of file #82

Open
FredericBGA opened this issue Sep 19, 2016 · 2 comments
Open

[blastxml_to_tabular] Add an option to print Header of file #82

FredericBGA opened this issue Sep 19, 2016 · 2 comments

Comments

@FredericBGA
Copy link
Contributor

Hello

I have modified the python script and its XML file in order to be able to print (or not) a header for the tabular file.

Is it possible to merge this within the current branch ?

Fred

blastxml_to_tabular.py-addPrintHeaderOption.patch.txt
blastxml_to_tabular.xml-addPrintHeaderOption.patch.txt

@peterjc
Copy link
Owner

peterjc commented Sep 19, 2016

I think the ideal fix is #84 (only filed today, but that's been a wish list for years now).

Unfortunately while your proposal should work nicely with Galaxy which (in places) understands the # header line convention, this does not match how the NCBI does its own (optional) headers. Does this bother you?

Regarding the proposed command line API:

parser.add_option('-p', '--print', dest='pheader', default=None, help='print header of file (default to None')

Rather than -p 1 and --print 1 (taking a meaningless argument), this should be a switch (i.e. -p only, or --print only). However, name wise, I'd probably go for --header instead.

@FredericBGA
Copy link
Contributor Author

Hello

Unfortunately while your proposal should work nicely with Galaxy which (in places) understands the # header line convention, this does not match how the NCBI does its own (optional) headers. Does this bother

not at all.

Regarding the proposed command line API your proposal is much better indeed . I'm not (yet) fluent in python (neither in english !) and I've done something quick based on a copy/paste of the other options defined in the file !

Thank you for this quick reply. Your wrappers are great, and this point is far from being an issue.

Fred

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants