React dependency

[pgherveou]

Hi Pete. Cool package!
Shouldn't we use a peer dependency for react-tools in this package ?
or maybe use "react-tools": "0.x" notation to make it more flexible

[petehunt]

Why peer dependency? It's already in dependencies (I'm not the best with npm I'm afraid)

[pgherveou]

Well I might be wrong,
But my understanding is that node-jsx in meant to be used with a host React app

So you don't want this package to install its own "react-tools" dependency when
you install it with npm install but rather use the one you have already declared in your project.
(this is the case today if I use react tools 0.5)

I read that pretty quickly :) but the details are here http://blog.nodejs.org/2013/02/07/peer-dependencies/

So basically I would write package.json like that:

{
  "name": "node-jsx",
  "version": "0.0.0",
  "description": "transparently require() jsx from node",
  "main": "index.js",
  "peerDependencies": {
    "react-tools": "0.x"
  },
  "scripts": {
    "test": "echo \"Error: no test specified\" && exit 1"
  },
  "repository": "",
  "author": "Pete Hunt",
  "license": "Apache 2"
}