Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(mu/su): allow multiple Type tags #1025

Open
VinceJuliano opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1043
Open

feat(mu/su): allow multiple Type tags #1025

VinceJuliano opened this issue Oct 2, 2024 · 0 comments · May be fixed by #1043
Assignees
@Jeremiahstockdale
Labels
mu ao Messenger unit su ao Scheduler Unit

Comments

@VinceJuliano
Copy link
Collaborator

Background

The MU overwrites the Type tag on Message results to be Message based on the protocol. The SU will reject if Type tag is not Message or Process.

Solution

Allow multiple Type tags in both but ensure the first Type tag after Data-Protocol is Message or Process
@VinceJuliano VinceJuliano added su ao Scheduler Unit mu ao Messenger unit labels Oct 2, 2024
@VinceJuliano VinceJuliano self-assigned this Oct 2, 2024
@jfrain99 jfrain99 mentioned this issue Oct 14, 2024
Merged
Jeremiahstockdale added a commit that referenced this issue Oct 15, 2024
@Jeremiahstockdale
fix(mu): mu overwriting message types #1025
a6da18f
@Jeremiahstockdale Jeremiahstockdale linked a pull request Oct 15, 2024 that will close this issue
Open
Jeremiahstockdale added a commit that referenced this issue Oct 16, 2024
@Jeremiahstockdale
test(mu): buildandsign does not include the type message tag #1025
253a9ee
Jeremiahstockdale added a commit that referenced this issue Oct 16, 2024
@Jeremiahstockdale
refactor(mu): add Type Message to all build and signs #1025
b9288ca
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Jeremiahstockdale Jeremiahstockdale

Labels
mu ao Messenger unit su ao Scheduler Unit
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(mu): mu overwriting message types #1025 permaweb/ao
2 participants
@VinceJuliano @Jeremiahstockdale