Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Need to handle when decompiler comments out external variables #2

Open
pdreiter opened this issue Mar 29, 2024 · 0 comments
Open

Need to handle when decompiler comments out external variables #2

pdreiter opened this issue Mar 29, 2024 · 0 comments
Assignees
Labels
bug Something isn't working

Comments

@pdreiter
Copy link
Owner

Looks like hex-rays comments out external data declarations, which makes prd ignore them:

For example, from Rode0days 19.11 sqliteB4 function output_file_close:

//--------------------------------------------------------------------
// Data declarations

// extern struct _IO_FILE *stderr;
// extern struct _IO_FILE *stdout;

this is not processed correctly by PRD. (only effects 2 of 11615 functions tested)

@pdreiter pdreiter self-assigned this Mar 29, 2024
@pdreiter pdreiter added the bug Something isn't working label Mar 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant