diff --git a/config_py/fixtures/__init__.py b/config_py/fixtures/__init__.py index e9f67cd..f97ee9a 100644 --- a/config_py/fixtures/__init__.py +++ b/config_py/fixtures/__init__.py @@ -1,4 +1,4 @@ from config_py.lib import import_config -import_config(globals(){arguments_str}) \ No newline at end of file +import_config(globals(){arguments_str}) diff --git a/config_py/lib/__init__.py b/config_py/lib/__init__.py index 389e4c1..539d337 100644 --- a/config_py/lib/__init__.py +++ b/config_py/lib/__init__.py @@ -34,17 +34,15 @@ def import_config(glob, **kwargs): env_var_name = kwargs.get('env_var', 'WSGI_ENV') env = get_environment(env_var_name) - conf_module = '.config_{}'.format(env) - conf_package = '{}config'.format(package) + conf_module = '{}config.config_{}'.format(package, env) try: my_module = importlib.import_module( - conf_module, - conf_package + conf_module ) - except ModuleNotFoundError: + except ImportError: logging.warning('There is no configuration module for environment "{}"'.format(env)) logging.warning( - 'Expected module to be present "{}{}"'.format(conf_package, conf_module) + 'Expected module to be present "{}"'.format(conf_module) ) return diff --git a/test/bin/config_py_test.py b/test/bin/config_py_test.py index 56914a4..bceb9b0 100644 --- a/test/bin/config_py_test.py +++ b/test/bin/config_py_test.py @@ -36,14 +36,14 @@ def test_create_config_root(self, mock_get_cwd): self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'root', '__init__.py_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'root', '__init__.py'), os.path.join(SCRIPT_DIR, CONF_DIR_NAME, '__init__.py') ) ) self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'root', DEV_FILE + '_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'root', DEV_FILE), os.path.join(SCRIPT_DIR, CONF_DIR_NAME, DEV_FILE) ) ) @@ -58,14 +58,14 @@ def test_create_config_with_env_root(self, mock_get_cwd): self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'root', 'env', '__init__.py_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'root', 'env', '__init__.py'), os.path.join(SCRIPT_DIR, CONF_DIR_NAME, '__init__.py') ) ) self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'root', DEV_FILE + '_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'root', DEV_FILE), os.path.join(SCRIPT_DIR, CONF_DIR_NAME, DEV_FILE) ) ) @@ -94,7 +94,7 @@ def test_create_config_package(self, mock_get_cwd): self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'package', '__init__.py_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'package', '__init__.py'), os.path.join( SCRIPT_DIR, CUST_MODULE_DIST, @@ -106,7 +106,7 @@ def test_create_config_package(self, mock_get_cwd): self.assertTrue( filecmp.cmp( - os.path.join(SCRIPT_DIR, 'fixtures', 'package', DEV_FILE + '_'), + os.path.join(SCRIPT_DIR, 'fixtures', 'package', DEV_FILE), os.path.join( SCRIPT_DIR, CUST_MODULE_DIST, diff --git a/test/bin/fixtures/package/__init__.py_ b/test/bin/fixtures/package/__init__.py similarity index 97% rename from test/bin/fixtures/package/__init__.py_ rename to test/bin/fixtures/package/__init__.py index fe1ea50..15973db 100644 --- a/test/bin/fixtures/package/__init__.py_ +++ b/test/bin/fixtures/package/__init__.py @@ -1,4 +1,4 @@ from config_py.lib import import_config -import_config(globals(), package='my_module.', env_var='WSGI_ENV') \ No newline at end of file +import_config(globals(), package='my_module.', env_var='WSGI_ENV') diff --git a/test/bin/fixtures/package/config_dev.py_ b/test/bin/fixtures/package/config_dev.py similarity index 100% rename from test/bin/fixtures/package/config_dev.py_ rename to test/bin/fixtures/package/config_dev.py diff --git a/test/bin/fixtures/root/__init__.py b/test/bin/fixtures/root/__init__.py new file mode 100644 index 0000000..0ddbb23 --- /dev/null +++ b/test/bin/fixtures/root/__init__.py @@ -0,0 +1,4 @@ +from config_py.lib import import_config + + +import_config(globals(), env_var='WSGI_ENV') diff --git a/test/bin/fixtures/root/__init__.py_ b/test/bin/fixtures/root/__init__.py_ deleted file mode 100644 index 8056232..0000000 --- a/test/bin/fixtures/root/__init__.py_ +++ /dev/null @@ -1,4 +0,0 @@ -from config_py.lib import import_config - - -import_config(globals(), env_var='WSGI_ENV') \ No newline at end of file diff --git a/test/bin/fixtures/root/config_dev.py_ b/test/bin/fixtures/root/config_dev.py similarity index 100% rename from test/bin/fixtures/root/config_dev.py_ rename to test/bin/fixtures/root/config_dev.py diff --git a/test/bin/fixtures/root/env/__init__.py b/test/bin/fixtures/root/env/__init__.py new file mode 100644 index 0000000..98ff969 --- /dev/null +++ b/test/bin/fixtures/root/env/__init__.py @@ -0,0 +1,4 @@ +from config_py.lib import import_config + + +import_config(globals(), env_var='MY_ENV') diff --git a/test/bin/fixtures/root/env/__init__.py_ b/test/bin/fixtures/root/env/__init__.py_ deleted file mode 100644 index 52f26d7..0000000 --- a/test/bin/fixtures/root/env/__init__.py_ +++ /dev/null @@ -1,4 +0,0 @@ -from config_py.lib import import_config - - -import_config(globals(), env_var='MY_ENV') \ No newline at end of file diff --git a/test/lib/lib_tests.py b/test/lib/lib_tests.py index cb0916a..9c8a7bb 100644 --- a/test/lib/lib_tests.py +++ b/test/lib/lib_tests.py @@ -33,8 +33,7 @@ def test_import_config_with_package(self, mock_importmodule, mock_getenv): import_config(global_mock, package='my.package.') mock_importmodule.assert_called_with( - '.config_production', - 'my.package.config' + 'my.package.config.config_production' ) to_be_exported['env'] = ANY global_mock.update.assert_called_with(to_be_exported) diff --git a/version/__init__.py b/version/__init__.py index 3dc1f76..485f44a 100644 --- a/version/__init__.py +++ b/version/__init__.py @@ -1 +1 @@ -__version__ = "0.1.0" +__version__ = "0.1.1"