Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

EdDSA: add validate-after-sign #106

Open
paulmillr opened this issue Dec 31, 2023 · 3 comments
Open

EdDSA: add validate-after-sign #106

paulmillr opened this issue Dec 31, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@paulmillr
Copy link
Owner

openpgpjs@559e53c

@larabr a pr would be highly appreciated!
@larabr
Copy link

larabr commented Jan 4, 2024

Sure, I can open it. FWIW we are still gathering some stats to understand if this sort of bitflips do happen in the wild. Let me know if you want to add this feature regardless 👌

@paulmillr
Copy link
Owner Author

It's only few lines of code - seems useful "just in case".

@paulmillr paulmillr added the enhancement New feature or request label Feb 7, 2024
@larabr
Copy link

larabr commented Mar 22, 2024

(Sorry but I haven't gotten around to opening the PR yet).

FYI there is now an RFC draft about non-deterministic EdDSA signature to tackle the underlying issue: https://datatracker.ietf.org/doc/html/draft-irtf-cfrg-det-sigs-with-noise-03 . I think implementing that variant is probs a better solution for people who do not care about the deterministic result 🙂

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@paulmillr @larabr