Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Testing SbmlInterface on the sbml test suite. #9

Open
anandijain opened this issue Feb 27, 2021 · 2 comments
Open

Testing SbmlInterface on the sbml test suite. #9

anandijain opened this issue Feb 27, 2021 · 2 comments

Comments

@anandijain
Copy link
Collaborator

Hello, thanks for this. This is really cool.

You might be aware of the sbml test suite, which would be great to test how much coverage this package has in converting models to MTK.

This is my experience so far is contained in this gist.

It should be a copy pasteable mwe (modulo file paths).

I basically just cloned the suite, grabbed all the xmls and ran it thru your functions, catching errors along the way.

Assignment rules are not implemented. is the error I got the most, and prevented all of the models in the suite from working with sbml2odesystem.

I'm interested in getting this package up to speed so let me know what I can do, or good places to start!

@anandijain
Copy link
Collaborator Author

anandijain commented Feb 27, 2021

I downloaded a random 100 from https://www.ebi.ac.uk/biomodels/ and ran the gist from earlier. Ran into this:

julia> ps = getparameters.(models)
ERROR: type Nothing has no field getNumParameters

when looping with try catch I get ERROR: MethodError: no method matching round(::Num, ::RoundingMode{:Down})

lmk if u need traces

@anandijain
Copy link
Collaborator Author

@paulflang hey i got an email notification that you replied but can't see it here, i DMd u on julia slack.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant