-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add configuration for semantic release #30
Comments
Related to #3 |
If we do add configuration, we shouldn't run it though (so #3 should be closed in my opinion). |
I think it would be beneficial for us to have the automated release process running here even if we won't actually use the package, as that would make it a lot easier for us to identify if any issues with the process come up before they actually impact consumers. More than happy to discuss further though. |
Adding a package that is created from this might send the message that the npm package is what people should use. Since you'd want to validate any of those assumptions before merging a PR, I don't quite see how releasing on merge would provide value. It only will tell you after your code is in main that there is something wrong with it. A seed validation process could be useful, but that would be outside of this repo (or as a separate package within it that runs some validation process after generation). This is a template repo - what would the package contain? Is there a generated package.json file that tests your generate steps, and when would that be created? On merge to main or in the pull request build step? |
No description provided.
The text was updated successfully, but these errors were encountered: