Grunt plugin

[hjylewis]

Is there a reason this isn't set up as a grunt plugin for easy installation and configuration using grunt.loadNpmTasks('edition-node-grunt') and grunt.initConfig instead of the config.json file?

This would avoid the mess that occurs if one wanted to run patternlab node as a npm dependency.

[bmuenzenmeyer]

At one time, I packaged up "standard" grunt and gulp tasks within core and then a user could directly consume them, but this was still inadequate. My understanding is that someone can actually require a gruntfile or gulpfile directly (http://macr.ae/article/splitting-gulpfile-multiple-files.html at least for gulp) making these still consumeable.

This would avoid the mess that occurs if one wanted to run patternlab node as a npm dependency.

That documentation is 1.X only and I doubt it applies to the 2.X code anymore. With 2.0, we fully intended Pattern Lab to act as an ecosystem and have focused on standalone first (it's hard enough making everything work, let alone make PL consumable in every which way people request). We expect people to write their own editions - and therefore the tasks that ship with this repo and it's gulp sister are samples (albeit samples most people would find mandatory).

That said, if you can find patterns that match the spirit of my above comment but make for more consumable code, please submit a PR!

[hjylewis]

Thanks for the response! Yeah, I think a couple small changes might make it more consumable so I'll make a PR when I get a chance. I'm still figuring out my way around Pattern Lab so let me know if any of my changes aren't align with the spirit.

[bmuenzenmeyer]

That would be much appreciated!

On Tue, Aug 2, 2016, 3:47 PM Henry Lewis [email protected] wrote:

Thanks for the response! Yeah, I think a couple small changes might make
it more consumable so I'll make a PR when I get a chance. I'm still
figuring out my way around Pattern Lab so let me know if any of my changes
aren't align with the spirit.

—
You are receiving this because you commented.

Reply to this email directly, view it on GitHub
#9 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/AASNww7u61LXlPJky3rtlztv5TKYb0Ztks5qb6zegaJpZM4JaN9d
.