Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merging "support for xbox360 class controllers, that need initialisation" to upstream xpad #283

Open
nondebug opened this issue Aug 9, 2024 · 2 comments

Comments

@nondebug
Copy link

nondebug commented Aug 9, 2024

@Oblomov's PR #120 was merged 3 years ago and fixes a number of third-party Xbox 360 controllers, including Elecom JC-U4013SBK. It would be great to get these fixes upstreamed.

Is there a reason this can't be upstreamed? What needs to happen before it can be merged?

@Oblomov
Copy link
Contributor

Oblomov commented Aug 9, 2024

FWIW the kernel driver seems to have some related changes that fix initialization of these controllers. I've been using the kernel driver instead of this module for a while now without issues.

@paroj
Copy link
Owner

paroj commented Oct 18, 2024

try changing this line to if(0):

xpad/xpad.c

Line 2008 in c379818

if (xpad->xtype == XTYPE_XBOX360) {

and check whether your controller still works.

we currently send both init sequences to xpad360 controllers. What upstream does and what we did previously. I cannot verify which one is better, so I have to wait for reports.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants