Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use batched ed25519 signatures verification #53

Closed
tomaka opened this issue Oct 5, 2020 · 2 comments · Fixed by #570
Closed

Don't use batched ed25519 signatures verification #53

tomaka opened this issue Oct 5, 2020 · 2 comments · Fixed by #570

Comments

@tomaka
Copy link
Contributor

tomaka commented Oct 5, 2020

I didn't realize that they were broken.

@tac0turtle
Copy link

Not sure how its broken, but a suggestion would be to adopt zip215: https://hdevalence.ca/blog/2020-10-04-its-25519am. https://github.com/ZcashFoundation/ed25519-zebra already implements it and is safe to use in consensus critical areas.

@burdges
Copy link

burdges commented Oct 27, 2020

Yup dalek-cryptography/ed25519-dalek#117 It becomes safe if one always uses stricter verification, and less nasty if one only ever uses one unique deterministic batch. In the second case, a node could create a block with all valid signatures that passes validation, but technically contains some invalid signatures.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants