Without sudo the trap handler may loop

[S0AndS0]

Describe the bug

If torrific-lynx script is run without --disable-socat flag, and sudo permissions are denied, the trap handler may trigger. When exiting on some systems this may cause a loop where sudo permissions are requested until a passphrase is entered.

---

To Reproduce

Steps to reproduce the behavior:

1. Run torrific-lynx without --disable-socat flag

2. Press Ctrl^c when prompted for passphrase

3. Continue pressing Ctrl^c when prompted for passphrase

---

Expected behavior

Script should terminate after pressing Ctrl^c

Desktop (please complete the following information):

• OS: Manjaro Linux

• Version: 21.0.7

---

Additional context

Instead of --disable-socat flag it may be better to use an enable prefix for opting-in to DNS over Tor features.

This bug may be caused by scripted logic operators, check shellcheck reports [SC2015]

Note that A && B || C is not if-then-else. C may run when A is true. [SC2015]

Example (generate SC2015)

[[ "${HOME}" == '/root' ]] && ! (( 1 + 1 )) && {
  echo 'yep'
} || {
  echo 'nope'
}

Example (fix SC2015)

if [[ "${HOME}" == '/root' ]] && ! (( 1 + 1 )); then
  echo 'yep'
else
  echo 'nope'
fi