Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change e2e tests to use common parallaxsecond docker image #33

Open
jn9e9 opened this issue Mar 17, 2021 · 1 comment
Open

Change e2e tests to use common parallaxsecond docker image #33

jn9e9 opened this issue Mar 17, 2021 · 1 comment

Comments

@jn9e9
Copy link
Collaborator

jn9e9 commented Mar 17, 2021

I think it's fine to remove those Dockerfile and directly run ghcr.io/parallaxsecond/parsec-service-test-all in your test script.

Originally posted by @hug-dev in #32 (comment)

ionut-arm added a commit that referenced this issue Mar 21, 2021
@jn9e9
Copy link
Collaborator Author

jn9e9 commented Nov 3, 2021

@hug-dev I think the current way of doing this works well. The extra docker container allows for the go lang installation which is needed (we shouldn't need to download toolchain every time we want to run ci-tests.)
Also, golang ci tests don't need to have parsec service rebuilt every time. This shortens the build/test lifecycle for debugging ci-tests. Can add a script option to re-build the docker container if required.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant