Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In combine_fragments, cast fragments to list if improperly decoded #548

Merged
merged 11 commits into from
Jul 27, 2023

Conversation

cisaacstern
Copy link
Member

Some additional logging to aid in debugging Dataflow-specific error reported in leap-stc/data-management#33 (comment)

@cisaacstern
Copy link
Member Author

Thanks to @alxmrs for pointing out that Dataflow / Cloud Logging may not be able to materialize logger.debug calls, which appears to be the case, and that using logger.info calls would fix this issue (of not being able to see the logs on GCP). 🙃

@cisaacstern cisaacstern changed the title Additional logging messages In combine_fragments, cast fragments to list if improperly decoded Jul 27, 2023
@cisaacstern cisaacstern marked this pull request as ready for review July 27, 2023 21:58
@cisaacstern
Copy link
Member Author

Going to merge this to unblock leap-stc/data-management#33 (so we don't have to pull from a PR branch of -recipes there).

IMO this is a temporary patch for #552 which should be reverted if/when a better fix for #552 is implemented.

@cisaacstern cisaacstern merged commit a22e6aa into main Jul 27, 2023
11 checks passed
@cisaacstern cisaacstern deleted the combine-fragments-debug-logging branch July 27, 2023 22:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant