Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential regression induced by #57347 #57640

Closed
DeaMariaLeon opened this issue Feb 27, 2024 · 1 comment
Closed

Potential regression induced by #57347 #57640

DeaMariaLeon opened this issue Feb 27, 2024 · 1 comment

Comments

@DeaMariaLeon
Copy link
Member

PR #57347 May have induced a regression.
Benchmark:
frame_methods.AsType.time_astype (Python) with copy=False, from_to_dtypes=('float64[pyarrow]', 'float64[pyarrow]')

@phofl

Screenshot 2024-02-27 at 09 47 41
@phofl
Copy link
Member

phofl commented Feb 27, 2024

This is overhead that is generated by the warning that is raised now, so closing as expected.

We should get back to the original runtime by removing the copy keyword

@phofl phofl closed this as completed Feb 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants