Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CoW: Remove remaining cow occurrences from tests #57477

Merged
merged 2 commits into from
Feb 19, 2024

Conversation

phofl
Copy link
Member

@phofl phofl commented Feb 17, 2024

This should be all of them

@phofl phofl added this to the 3.0 milestone Feb 17, 2024
Copy link
Member

@jorisvandenbossche jorisvandenbossche left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, looks good!

@jorisvandenbossche jorisvandenbossche changed the title Remove remaining cow occurrences from tests CoW: Remove remaining cow occurrences from tests Feb 19, 2024
@jorisvandenbossche jorisvandenbossche merged commit 2617822 into pandas-dev:main Feb 19, 2024
46 of 47 checks passed
@jorisvandenbossche
Copy link
Member

For the skipped fastparquet tests, was going to open an issue on their side, but commented on an open one (they already saw the same failures on their CI in the meantime, dask/fastparquet#919)

@phofl phofl deleted the cow_tests_3 branch February 19, 2024 20:29
@phofl
Copy link
Member Author

phofl commented Feb 19, 2024

Tbh I don’t really care. Not objecting to you investing time, but won’t bother with this

we deprecated this in dask/dask already and I would support a similar thing jere

pmhatre1 pushed a commit to pmhatre1/pandas-pmhatre1 that referenced this pull request May 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants