Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do we need to use fixed NonfungiblePositionManager contract address #66

Open
musk-j opened this issue Jul 24, 2024 · 0 comments
Open

Do we need to use fixed NonfungiblePositionManager contract address #66

musk-j opened this issue Jul 24, 2024 · 0 comments

Comments

@musk-j
Copy link

musk-j commented Jul 24, 2024

In withdrawLiquidityFromV3, the migrator contract interacts with the external nfp contract and it comes from users' input.
IV3NonfungiblePositionManager nfp = IV3NonfungiblePositionManager(v3PoolParams.nfp);

Not sure we need to simply use fixed NonfungiblePositionManager contract. I do not see obvious risks though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant