Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Potential issue with setup.py #29

Open
a-larkins99 opened this issue Jan 12, 2024 · 0 comments
Open

Potential issue with setup.py #29

a-larkins99 opened this issue Jan 12, 2024 · 0 comments
Labels
potential issue Something that may cause an issue in the future

Comments

@a-larkins99
Copy link
Collaborator

Context

The current method utilised to produce the .whl file of python setup.py bdist_weel is considered deprecated and is discouraged (https://setuptools.pypa.io/en/latest/userguide/quickstart.html) in favour of using python -m build.

Issue

Currently it is possible to feed cmake options to setup.py and subsequently to the cmake build command by running a command, such as the following where we are specifying the specific version of Matlab to use.

python setup.py bdist_wheel -DMatlab_ROOT_DIR="path/to/matlab/"

This currently works fine, however in the future when we may wish to transition to using python -m build or similar, this functionality will need to be revisited, providing we still require it. I have been unable to work out a solution to this so far with python -m build -DMatlab_ROOT_DIR="path/to/matlab/" not being possible currently.

@a-larkins99 a-larkins99 added question Further information is requested potential issue Something that may cause an issue in the future and removed question Further information is requested labels Jan 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
potential issue Something that may cause an issue in the future
Projects
None yet
Development

No branches or pull requests

1 participant