Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sigvar needs general way of handling masked data #354

Open
tgperring opened this issue Apr 29, 2021 · 1 comment
Open

sigvar needs general way of handling masked data #354

tgperring opened this issue Apr 29, 2021 · 1 comment
Assignees

Comments

@tgperring
Copy link
Collaborator

When any object that has masked data has binary operations implemented on it, the current method for handling it has to be implemented in a bespoke fashion. However, sigvar can in principle support a consistent way of handling this situation. Sigvar lies at the root of unary and binary operations, and in the new Matlab classdef implementation it has a property 'msk' which can be used for this purpose which is currently not used.

It will require some additional required methods for classes that use sigvar to extract the mask, as well as modification to the code of sigvar to use 'msk' internally. Not high priority.

@tgperring tgperring self-assigned this Apr 29, 2021
@tgperring
Copy link
Collaborator Author

Addendum: The one potential priority is to reolve the case of binary operations for dnd objects in Horace: currently if there are empty bins (i.e. npix=0 for one or more bins) in both w1 and w2 in an operation like w1+w2, then this is not handled correctly. The fixup in Horace that existed prior to the the refactoring of class sigvar has been removed in anticipation of this ticket implemented; there was no uinit test that caught this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant