Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Duplicated SPE readers in codebase #145

Open
ghost opened this issue Apr 22, 2020 · 0 comments
Open

Duplicated SPE readers in codebase #145

ghost opened this issue Apr 22, 2020 · 0 comments
Assignees
Labels
HoraceMirror To be removed? I/O Label related to disk usage

Comments

@ghost
Copy link

ghost commented Apr 22, 2020

There are two instances of SPE readers in the codebase:

The functions are pretty similar, the @loader_ascii version seems to have built upon a copy of the @spe version.

We should remove one version and replace any usages with the other version. My first instinct is that the @spe version should be removed, but part of this ticket will be to decide which reader to keep and which to replace.

Outputs:

  • There should only be one SPE file reader

CM 17.10.23 - UPDATE
the specific names mentioned here are no longer present but similar ones without matlab are.
To be reviewed and prioritised.

@oerc0122 oerc0122 added HoraceMirror To be removed? I/O Label related to disk usage labels Dec 3, 2020
@cmarooney-stfc cmarooney-stfc self-assigned this Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
HoraceMirror To be removed? I/O Label related to disk usage
Projects
None yet
Development

No branches or pull requests

2 participants