From 68958e394f7af8495aa78ce8753b52deb471470d Mon Sep 17 00:00:00 2001 From: Saw-jan Date: Fri, 20 Sep 2024 16:41:39 +0545 Subject: [PATCH] test: fix lint --- test/gui/.pylintrc | 3 +++ test/gui/shared/scripts/helpers/api/sharing_helper.py | 2 +- test/gui/shared/scripts/pageObjects/PublicLinkDialog.py | 6 +++--- 3 files changed, 7 insertions(+), 4 deletions(-) diff --git a/test/gui/.pylintrc b/test/gui/.pylintrc index d335612b0ff..146f973f5ed 100644 --- a/test/gui/.pylintrc +++ b/test/gui/.pylintrc @@ -37,10 +37,13 @@ unsafe-load-any-extension=no [BASIC] attr-naming-style=snake_case +; TODO: enable it later +; class-attribute-naming-style=snake_case class-const-naming-style=UPPER_CASE class-naming-style=PascalCase const-naming-style=UPPER_CASE function-naming-style=snake_case +inlinevar-naming-style=snake_case method-naming-style=snake_case module-naming-style=any variable-naming-style=snake_case diff --git a/test/gui/shared/scripts/helpers/api/sharing_helper.py b/test/gui/shared/scripts/helpers/api/sharing_helper.py index 703a49cc86e..9a4b60cd937 100644 --- a/test/gui/shared/scripts/helpers/api/sharing_helper.py +++ b/test/gui/shared/scripts/helpers/api/sharing_helper.py @@ -106,7 +106,7 @@ def share_resource(user, resource, receiver, permissions, receiver_type): 'permissions': permissions, } response = request.post(url, body, user=user) - request.assertHttpStatus( + request.assert_http_status( response, 200, f"Failed to share resource '{resource}' to {receiver_type} '{receiver}'", diff --git a/test/gui/shared/scripts/pageObjects/PublicLinkDialog.py b/test/gui/shared/scripts/pageObjects/PublicLinkDialog.py index 5c425a2ac89..536d8732c22 100644 --- a/test/gui/shared/scripts/pageObjects/PublicLinkDialog.py +++ b/test/gui/shared/scripts/pageObjects/PublicLinkDialog.py @@ -92,7 +92,7 @@ class PublicLinkDialog: "%d/%m/%y", ] # to store current default public link expiry date - defaultExpiryDate = "" + default_expiry_date = "" @staticmethod def parse_date(date): @@ -107,11 +107,11 @@ def parse_date(date): @staticmethod def set_default_expiry_date(default_date): - PublicLinkDialog.defaultExpiryDate = PublicLinkDialog.parse_date(default_date) + PublicLinkDialog.default_expiry_date = PublicLinkDialog.parse_date(default_date) @staticmethod def get_default_expiry_date(): - return PublicLinkDialog.defaultExpiryDate + return PublicLinkDialog.default_expiry_date @staticmethod def open_public_link_tab():