Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hard coding clojure-mode for cljs will cause problems #228

Open
arichiardi opened this issue Mar 10, 2016 · 7 comments
Open

Hard coding clojure-mode for cljs will cause problems #228

arichiardi opened this issue Mar 10, 2016 · 7 comments

Comments

@arichiardi
Copy link
Contributor

I have had this problem while updating cider to 0.11.0 (you can see that I am keeping up with the updates, but not maintaining publicly this here) because of the following line:

emacs-live/packs/dev/clojure-pack/config/clojure-conf.el

Lines 58 to 59 in 7983bc7

(setq auto-mode-alist (append '(("\\.cljs$" . clojure-mode))
auto-mode-alist))

The two lines will need to be removed, I can provide a patch when Emacs Live moves to 0.11.0 as well.
@samaaron
Copy link
Member

Please do provide a patch :-)

@arichiardi
Copy link
Contributor Author

Of course, but it does not make sense now, I will wait the bump to 0.11.0

@arichiardi
Copy link
Contributor Author

Ah you mean a patch for 0.11.0? I was thinking about it, will try to find time ok?

coldnew added a commit to coldnew/coldnew-emacs that referenced this issue Mar 11, 2016
@coldnew
clojure: disable mode-alist for cider-repl
d490a26 
When playing with re-natal, I can't use C-x C-e to send latest sexp to
figwheel, cider will show something like:

    user-error: `cider-eval-last-sexp' needs a Clojure REPL.
    If you don't know what that means, you probably need to jack-in (`C-c M-j’).

After comment out my mode-alist setting in .emacs, this issue gone.

version:

  CIDER 0.12.0snapshot (package: 20160306.1636)
  [cider/cider-nrepl "0.12.0-SNAPSHOT"]

related issue:

  overtone/emacs-live#228
  clojure-emacs/cider-nrepl#301

Signed-off-by: Yen-Chin Lee <[email protected]>
@coldnew coldnew mentioned this issue Mar 11, 2016
Closed
@Malabarba
Copy link

For the record, there's no reason to wait for cider 0.11.0 (which is already out anyway, btw). Clojure-mode has had a clojurescript-mode for a while now, and that's what people should be using for clojurescript files.

@arichiardi
Copy link
Contributor Author

For the record, I did not know 😄 I will patch!

@Malabarba
Copy link

😉 👍

@arichiardi arichiardi mentioned this issue Mar 11, 2016
Merged
@arichiardi
Copy link
Contributor Author

Done, and btw @samaaron in the process of upgrading the clojure-pack, clj-refactor had some additional modules to add, I think I worked already on this here so feel free to have a look at:

I know I should rebase to align myself to master but I think I will do when emacs-live switches to cider 0.11.0 :D

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@samaaron @Malabarba @arichiardi