Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The process stops on error instead of continuing with the following repository. #437

Open
coni2k opened this issue Aug 3, 2023 · 2 comments · May be fixed by #438
Open

The process stops on error instead of continuing with the following repository. #437

coni2k opened this issue Aug 3, 2023 · 2 comments · May be fixed by #438

Comments

@coni2k
Copy link
Contributor

coni2k commented Aug 3, 2023

When the script encounters an error, it stops the process. Ideally, it should log the error and continue with the following repository.

This is not a convenient experience, especially when processing a huge number of repositories.

Command:

go run .\cmd\criticality_score -gcp-project-id=[Project ID] ".\output\repos.txt"

repos.txt content

https://github.com/404/repo-not-found -- A non-existent repo URL; the script will stop the process here
https://github.com/babel/babel -- And this one will not be processed

Output

> go run .\cmd\criticality_score -gcp-project-id=[Project ID] ".\output\repos.txt"
2023-08-03 12:28:10.466 INFO    Preparing default scorer
2023-08-03 12:28:11.827 INFO    deps.dev signal source enabled
2023-08-03 12:28:12.386 WARN    Repo cannot be collected        {"worker": 0, "url": "https://github.com/404/repo-not-found", "error": "repo failed: not found: https://github.com/404/repo-not-found"}
main.main.func1
        C:/Dev/Projects/Personal/GitHub/criticality_score_go/cmd/criticality_score/main.go:210
github.com/ossf/criticality_score/internal/workerpool.WorkerPool.func1
        C:/Dev/Projects/Personal/GitHub/criticality_score_go/internal/workerpool/workerpool.go:36
@coni2k coni2k linked a pull request Aug 3, 2023 that will close this issue
@sttor
Copy link

sttor commented Jul 22, 2024

@calebbrown

@Garcel
Copy link

Garcel commented Jul 31, 2024

Having this would be great!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants