Enhance inference in LieAlgebras, GSets, and MatrixGroups #4208
Conversation
lgoettgens
force-pushed
the
lg/Lie-type-instab
branch
from
edfa335
to
b9578e2
Compare
lgoettgens
force-pushed
the
lg/Lie-type-instab
branch
from
b9578e2
to
52f5271
Compare
|
Strange: On my computer, I cannot reproduce the errors reported for |
|
|
||
| Return the element of `I` with coefficient vector `v`. | ||
| """ | ||
| function (I::LieAlgebraIdeal{C})(v::Vector{C}) where {C<:FieldElem} | ||
| function (I::LieAlgebraIdeal{C})(v::AbstractVector{C}) where {C<:FieldElem} |
There was a problem hiding this comment.
At first I was concerned that this change might lead to funky behaviour if v does not use 1-based indexing. But then I noticed the call matrix(coefficient_ring(I), 1, length(v), v) below, so I think that will throw a suitable error in that case. Fine by me then.
There was a problem hiding this comment.
This gets caught by https://github.com/Nemocas/AbstractAlgebra.jl/pull/1864/files#diff-77fc321e067710edc4d1df4198d7b3c983ee423acee3295a333ac68533656322R1076, so it should be fine
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #4208 +/- ##
==========================================
- Coverage 84.60% 84.60% -0.01%
==========================================
Files 631 631
Lines 84939 84946 +7
==========================================
+ Hits 71864 71865 +1
- Misses 13075 13081 +6
|
lgoettgens
force-pushed
the
lg/Lie-type-instab
branch
from
e08dc61
to
63b14a4
Compare
# Conflicts: # Project.toml
Co-authored-by: Thomas Breuer <[email protected]>
# Conflicts: # Project.toml
Most of this was found using JET.
This needs Nemocas/AbstractAlgebra.jl#1864 to be available.