You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I'm getting a little worried the Wizard's state is becoming too confusing here - we've got a Payload Repositories field, a Custom Repositories field, and now a Recommended Repositories field.
I think that we should collapse these into a single field, SelectedRepositories, and then we can generate the payload and custom repositories fields when we generate the request.
This should make it much easier to ensure that bugs like this, where adding a new repo via the Proactive Assistance modal does not cause the repo to become selected on the repositories step, do not occur:
The text was updated successfully, but these errors were encountered:
Fair enough, I'll gladly take this one. Originally the step was just migrated to V2 with minimal refactoring, but as I started working on repo recommendations I've noticed a few things I'd like to do differently.
Merging all the repos into one field in the state sounds good, the recommended ones can be differentiated by a flag. This way we shouldn't lose any functionality/detail needed to render things properly.
I'm getting a little worried the Wizard's state is becoming too confusing here - we've got a Payload Repositories field, a Custom Repositories field, and now a Recommended Repositories field.
I think that we should collapse these into a single field, SelectedRepositories, and then we can generate the payload and custom repositories fields when we generate the request.
This should make it much easier to ensure that bugs like this, where adding a new repo via the Proactive Assistance modal does not cause the repo to become selected on the repositories step, do not occur:
The text was updated successfully, but these errors were encountered: